patek/patek.cz
9
0
Fork 0
Code Issues 4 Pull Requests 2 Packages Projects Releases Wiki Activity

Include <head> in baseof.html instead of partial, so we can use blocks. #1

New Issue
Closed
opened 2019-07-15 19:22:57 +00:00 by Greenscreener · 4 comments
Greenscreener commented 2019-07-15 19:22:57 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

As we discussed in issue #31 in gbl-site, blocks can be only used in base templates, thus I think we should move all code from partial head.html into baseof.html. @vojta001 u agree?

As we discussed in [issue #31 in gbl-site](https://github.com/vojta001/gbl-site/issues/31), blocks can be only used in base templates, thus I think we should move all code from partial head.html into baseof.html. @vojta001 u agree?
Greenscreener commented 2019-07-15 19:26:22 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

Also the <head> is not something, that is likely to be reused elsewhere, since there is only a single head, thus there is no need for it to be in a partial.

Also the `<head>` is not something, that is likely to be reused elsewhere, since there is only a single head, thus there is no need for it to be in a partial.
Greenscreener commented 2019-07-15 19:59:09 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

Did it anyway in bee0191.

Did it anyway in bee0191.
vojta001 commented 2019-07-16 08:44:53 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

I agree with this and also if the only effect on us is having to include <head> in our baseof.html it's too minor to be worth our time.

But I am still wondering what the real cause of this limitation is (if there is any). But that's a question for Hugo/Go html/template developers.

We can close this issue from my perspective.

I agree with this and also if the only effect on us is having to include `<head>` in our baseof.html it's too minor to be worth our time. But I am still wondering what the real cause of this limitation is (if there is any). But that's a question for Hugo/Go `html/template` developers. We can close this issue from my perspective.
Greenscreener commented 2019-07-16 11:39:50 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

closed

closed
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
easy pick
enhancement
fixneeded
help wanted
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
Broxon Dejwut (David Pacák) genibro (Michail Kornilov) jakub_kutsch (Jakub Kutscherauer) jan (Jan Černohorský) OndreasCZ (Ondřej Novák) sijisu (Šimon Jan Šustek) tomkys144 (Tomáš Kysela) vojta001 (Vojtěch Káně)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: patek/patek.cz#1