patek/patek.cz
9
0
Fork 0
Code Issues 4 Pull Requests 2 Packages Projects Releases Wiki Activity

Dark mode! #3

New Issue
Closed
opened 2019-07-16 13:15:43 +00:00 by sijisu · 30 comments
sijisu commented 2019-07-16 13:15:43 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

That would be really cool!

That would be really cool!
Greenscreener commented 2019-07-16 13:32:09 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

984c0e16d6

Consider it done! (well, almost)

984c0e16d67d75ab498d0008daf4eced2756eebd Consider it done! (well, almost)
Greenscreener commented 2019-08-03 21:47:18 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

A sightly off-topic note:
Use of the enhancement label is a little weird, since in every issue we discuss some enhancements...

A sightly off-topic note: Use of the `enhancement` label is a little weird, since in every issue we discuss some enhancements...
Greenscreener commented 2019-10-26 16:43:30 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

mentioned in commit b5013b5817

mentioned in commit b5013b5817e21602b8a6bc5a8b6f0c22436ea5bd
Greenscreener commented 2019-10-26 16:43:41 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

closed via commit b5013b5817

closed via commit b5013b5817e21602b8a6bc5a8b6f0c22436ea5bd
vojta001 commented 2019-10-26 20:49:25 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

@Greenscreener Is there an UI way to enable/disable this?

@Greenscreener Is there an UI way to enable/disable this?
sijisu commented 2019-10-26 20:52:39 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

+1

+1
Greenscreener commented 2019-10-26 20:55:40 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

reopened

reopened
craftak commented 2019-12-09 16:19:38 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

Is this still relevant? I am no saying that I am able to do something without fricking everything up...

EDIT: AFAIK English doesn't use actual in this context.

Is this still relevant? I am no saying that I am able to do something without fricking everything up... EDIT: AFAIK English doesn't use actual in this context.
Greenscreener commented 2019-12-09 16:23:44 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

Yes, the UI still doesn't exist. It's not really necessary, but it's nice to have someday in the future.

Yes, the UI still doesn't exist. It's not really necessary, but it's nice to have someday in the future.
craftak commented 2019-12-09 16:24:03 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

Missclicked... Sorry

Missclicked... Sorry
craftak commented 2019-12-09 16:25:29 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

How should it look? Just black background and grey text?

How should it look? Just black background and grey text?
vojta001 commented 2019-12-09 16:36:53 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

Well, I am not sure we understand each other. The dark mode already exists, the problem is, there is no way to trigger it, except knowing the URL, which is not truly user-friendly.

Well, I am not sure we understand each other. The dark mode [already exists](https://patek.cz/?darkmode=true), the problem is, there is no way to trigger it, except knowing the URL, which is not truly user-friendly.
vojta001 commented 2019-12-09 16:42:00 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

And as I have currently discovered, it not only exists, but is broken as well.

And as I have currently discovered, it not only exists, but is [broken as well](https://gitlab.com/patek-devs/patek.cz/commit/bcc8f50658cee1338732efe71401e28d577cffc2#note_257679698).
Greenscreener commented 2019-12-09 16:44:26 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

Really? Hadn't noticed. I'll fix it soon hopefully.

Really? Hadn't noticed. I'll fix it soon hopefully.
craftak commented 2019-12-09 16:45:32 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

Oh. Well, I think that I am useless even more now.... Is there ANYTHING that I could do on patek.cz?

Oh. Well, I think that I am useless even more now.... Is there ANYTHING that I could do on patek.cz?
vojta001 commented 2019-12-09 16:47:25 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

Yes of course, be so nice and create the UI to trigger the dark mode instead of creating the dark mode itself. I mean, a button or a switch, that will go to darkmode and back.

Yes of course, be so nice and create the UI to trigger the dark mode instead of creating the dark mode itself. I mean, a button or a switch, that will go to darkmode and back.
Greenscreener commented 2019-12-09 16:47:39 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

Try writing an article. You could also try to build the website on your local computer, as that should be the first step before doing any changes to the code.

Try writing an article. You could also try to build the website on your local computer, as that should be the first step before doing any changes to the code.
vojta001 commented 2019-12-09 16:48:16 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

No problem, fixing it is very straightforward, we should instead discuss the preferred way of fixing it

No problem, fixing it is very straightforward, we should instead discuss the preferred way of fixing it
Greenscreener commented 2019-12-09 16:50:06 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

A few points for the button:

  • we use Bulma, please use it
  • don't be like me and make the changes into a new branch. After you're done, submit a PR.
  • Make sure the build succeeds.
A few points for the button: - we use Bulma, please use it - don't be like me and make the changes into a new branch. After you're done, submit a PR. - Make sure the build succeeds.
craftak commented 2019-12-09 16:51:01 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

Well, as I said: I do not really know if I am able to do that, but I will try my best.

Well, as I said: I do not really know if I am able to do that, but I will try my best.
craftak commented 2019-12-09 16:51:32 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

1/ I love Bulma
2/ OK
3/ Ok

1/ I love Bulma 2/ OK 3/ Ok
craftak commented 2019-12-09 16:54:00 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

JS?

JS?
vojta001 commented 2019-12-09 19:29:45 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

You can use it, if you want.

You can use it, if you want.
vojta001 commented 2019-12-09 19:32:31 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

The most important part is IMHO making it in a branch not to upset others. Otherwise we will help you with everything.

For the git part, simply do git checkout -b <any branch name you want, usually author/featurename> and then git commit and git push --set-upstream origin <the branch name>

The most important part is IMHO making it in a branch not to upset others. Otherwise we will help you with everything. For the git part, simply do `git checkout -b <any branch name you want, usually author/featurename>` and then `git commit` and `git push --set-upstream origin <the branch name>`
vojta001 commented 2020-04-22 11:34:28 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

mentioned in issue #10

mentioned in issue #10
vojta001 commented 2020-04-22 11:35:05 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

@Dejwut Are you still willing to do this?

@Dejwut Are you still willing to do this?
Dejwut commented 2020-04-22 17:30:16 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

Yes, I am. Will get on it right after internship...

Yes, I am. Will get on it right after internship...
vojta001 commented 2020-09-30 20:17:57 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

mentioned in merge request !38

mentioned in merge request !38
vojta001 commented 2020-10-07 14:28:05 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

mentioned in commit edf81d21bb

mentioned in commit edf81d21bbd54017646c9ed5d2cf1483797b8921
sijisu commented 2021-08-03 19:03:29 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

mentioned in commit ebd2774eab

mentioned in commit ebd2774eab6a2ef3fb638e78ad01f076d6db2bc0
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
easy pick
enhancement
fixneeded
help wanted
No labels enhancement help wanted
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
Broxon Dejwut (David Pacák) genibro (Michail Kornilov) jakub_kutsch (Jakub Kutscherauer) jan (Jan Černohorský) OndreasCZ (Ondřej Novák) sijisu (Šimon Jan Šustek) tomkys144 (Tomáš Kysela) vojta001 (Vojtěch Káně)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: patek/patek.cz#3