patek/patek.cz
9
0
Fork 0
Code Issues 4 Pull Requests 2 Packages Projects Releases Wiki Activity

Dark mode - bold text is almost invisible #16

New Issue
Closed
opened 2020-10-14 17:23:04 +00:00 by fkmjec · 15 comments
fkmjec commented 2020-10-14 17:23:04 +00:00 (Migrated from gitlab.com)
Copy Link

Bold text stays dark even in dark mode and is therefore almost invisible on dark background.

Bold text stays dark even in dark mode and is therefore almost invisible on dark background.
vojta001 commented 2020-10-15 06:47:26 +00:00 (Migrated from gitlab.com)
Copy Link

added 1 design

added [1 design](/patek-devs/patek.cz/-/issues/16/designs?version=85551)
Greenscreener commented 2020-10-15 10:09:42 +00:00 (Migrated from gitlab.com)
Copy Link

This might be cool to use as an example in your talk about the internals of this website @vojta001.

This might be cool to use as an example in your talk about the internals of this website @vojta001.
vojta001 commented 2020-10-15 10:21:22 +00:00 (Migrated from gitlab.com)
Copy Link

Thanks for the idea, I'll do it.

Thanks for the idea, I'll do it.
vojta001 commented 2020-10-15 10:21:22 +00:00 (Migrated from gitlab.com)
Copy Link

assigned to @vojta001

assigned to @vojta001
ondrejmachota commented 2020-10-18 15:46:16 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit a1efc2117c

mentioned in commit a1efc2117c89982d61f47b1a674e0a18c1fa180b
vojta001 commented 2020-10-28 09:18:26 +00:00 (Migrated from gitlab.com)
Copy Link

added 1 design

added [1 design](/patek-devs/patek.cz/-/issues/16/designs?version=92335)
vojta001 commented 2020-10-28 09:19:59 +00:00 (Migrated from gitlab.com)
Copy Link

added 1 design

added [1 design](/patek-devs/patek.cz/-/issues/16/designs?version=92336)
vojta001 commented 2020-10-28 09:21:15 +00:00 (Migrated from gitlab.com)
Copy Link

The easy fix is to make the color white, however it looks much less emphasized than in light mode.

image

We can either accept it, or we can seek for other visual ways. I tried red, but I believe there has to be something much better.

image

BTW: I found @ondrejmachota prepared a fix in a1efc2117c, but it was missed as there is no MR for it.

The easy fix is to make the color white, however it looks much less emphasized than in light mode. ![image](/uploads/e4434691bd25a496ed7236fe71affaaf/image.png) We can either accept it, or we can seek for other visual ways. I tried red, but I believe there has to be something much better. ![image](/uploads/4c235fa9af0622f0b89cf8a5745c87a3/image.png) BTW: I found @ondrejmachota prepared a fix in a1efc2117c89982d61f47b1a674e0a18c1fa180b, but it was missed as there is no MR for it.
Greenscreener commented 2020-10-28 12:53:10 +00:00 (Migrated from gitlab.com)
Copy Link

I feel like when it is white, it has the exact same amount of emphasis as in black, but that might be just me. I would definitely not go for red, that doesn't look very good.

I feel like when it is white, it has the exact same amount of emphasis as in black, but that might be just me. I would definitely not go for red, that doesn't look very good.
vojta001 commented 2020-10-29 14:13:22 +00:00 (Migrated from gitlab.com)
Copy Link

@sijisu opinions?

@sijisu opinions?
sijisu commented 2020-10-29 14:45:34 +00:00 (Migrated from gitlab.com)
Copy Link

I agree with @Greenscreener on this one. It looks emphasised enough to me with white.

I agree with @Greenscreener on this one. It looks emphasised enough to me with white.
vojta001 commented 2020-10-29 18:58:40 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 7ec43bc5ca

mentioned in commit 7ec43bc5ca9eb7d0937724f420d68dae50b000d6
vojta001 commented 2020-10-29 18:59:54 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in merge request !48

mentioned in merge request !48
vojta001 commented 2020-10-29 19:00:41 +00:00 (Migrated from gitlab.com)
Copy Link

OK then – !48.

OK then – !48.
vojta001 commented 2020-10-29 22:20:24 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 7ab2c45019

mentioned in commit 7ab2c4501910640bc5697b41227f33cd0d37525c
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
bug

   
easy pick

   
enhancement

   
fixneeded

   
help wanted
No Label
bug
easy pick
enhancement
fixneeded
help wanted
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: patek/patek.cz#16
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?