patek/patek.cz
9
0
Fork 0
Code Issues 4 Pull Requests 2 Packages Projects Releases Wiki Activity

Pulled new version of logo CustomElement. #48

Merged
Greenscreener merged 0 commits from gs/logo-new-version-off-center-fix into master 2020-05-18 21:33:59 +00:00
Conversation 7 Commits - Files Changed -
Greenscreener commented 2020-05-18 17:49:33 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

Fixed an issue, where the logo would be off center, if the font-family attribute was applied to the element. I didn't really find out why it was happening, I just explicitly defined the font-family for the whole CustomElement and then recentered the logo using a constant.

Fixed an issue, where the logo would be off center, if the font-family attribute was applied to the element. I didn't really find out why it was happening, I just explicitly defined the font-family for the whole CustomElement and then recentered the logo using a constant.
vojta001 (Migrated from gitlab.com) approved these changes 2020-05-18 17:49:33 +00:00
Greenscreener commented 2020-05-18 17:52:19 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

Btw I used git bisect for this and 👌

Btw I used `git bisect` for this and :ok_hand:
vojta001 commented 2020-05-18 20:26:16 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

approved this merge request

approved this merge request
vojta001 commented 2020-05-18 20:26:50 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

With great history comes great ability

With great history comes great ability
Greenscreener commented 2020-05-18 21:33:55 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

resolved all threads

resolved all threads
Greenscreener commented 2020-05-18 21:34:00 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

mentioned in commit 83f2ca5967

mentioned in commit 83f2ca5967306e01996988c612185a8773e27a2f
Greenscreener commented 2020-05-18 21:34:00 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

merged

merged
Sign in to join this conversation.
Reviewers
No Reviewers
vojta001
Labels
Clear labels
bug
easy pick
enhancement
fixneeded
help wanted
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
Broxon Dejwut (David Pacák) genibro (Michail Kornilov) jakub_kutsch (Jakub Kutscherauer) jan (Jan Černohorský) OndreasCZ (Ondřej Novák) sijisu (Šimon Jan Šustek) tomkys144 (Tomáš Kysela) vojta001 (Vojtěch Káně)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: patek/patek.cz#48