patek/patek.cz
9
0
Fork 0
Code Issues 4 Pull Requests 2 Packages Projects Releases Wiki Activity

Linting discussion. #22

Merged
Greenscreener merged 0 commits from linters into master 2019-07-25 10:42:43 +00:00
Conversation 31 Commits - Files Changed -
Greenscreener commented 2019-07-17 18:05:58 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

The linters branch is going to contain all configs for linting and then will be eventually merged into master when it's ready. For now this MR will be used to discuss all code style and linting related questions.

The `linters` branch is going to contain all configs for linting and then will be eventually merged into master when it's ready. For now this MR will be used to discuss all code style and linting related questions.
Greenscreener commented 2019-07-17 18:46:21 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

added 1 commit

Compare with previous version

added 1 commit <ul><li>95b1c701 - WIP.</li></ul> [Compare with previous version](/patek-devs/patek.cz/merge_requests/1/diffs?diff_id=48493146&start_sha=abe356a802dc63341e60e5c30781eb651350bd46)
Greenscreener commented 2019-07-17 18:48:51 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

assigned to @sijisu and unassigned @Greenscreener

assigned to @sijisu and unassigned @Greenscreener
Greenscreener commented 2019-07-17 18:49:13 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

assigned to @vojta001 and unassigned @sijisu

assigned to @vojta001 and unassigned @sijisu
Greenscreener commented 2019-07-17 18:49:25 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

assigned to @Greenscreener and unassigned @vojta001

assigned to @Greenscreener and unassigned @vojta001
Greenscreener commented 2019-07-17 18:52:25 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

added 2 commits

  • 94462d17 - 1 commit from branch master
  • 8f88e542 - Merge branch 'master' into linters

Compare with previous version

added 2 commits <ul><li>94462d17 - 1 commit from branch <code>master</code></li><li>8f88e542 - Merge branch &#39;master&#39; into linters</li></ul> [Compare with previous version](/patek-devs/patek.cz/merge_requests/1/diffs?diff_id=48493914&start_sha=95b1c701edb2ea3e9380efdc9fa6143e81ff6c69)
vojta001 commented 2019-07-18 21:11:05 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

Thanks for your contribution.

I think we should only lint code from this repo/project; the quality of included code (patek-logo-element for example) is to be taken care of in their projects. I would probably solve it somehow generally e.g. putting external code to external subfolder and exclude it from the linting pattern.

Thanks for your contribution. I think we should only lint code from this repo/project; the quality of included code (patek-logo-element for example) is to be taken care of in their projects. I would probably solve it somehow generally e.g. putting external code to `external` subfolder and exclude it from the linting pattern.
Greenscreener commented 2019-07-19 09:45:40 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

While I agree, IMHO patek-logo can be linted too as it's developed alongside this project.

While I agree, IMHO patek-logo can be linted too as it's developed alongside this project.
Greenscreener commented 2019-07-19 10:07:33 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

added 1 commit

  • 69c9a96d - Added an html linter. It doesn't produce any errors. Either the code is...

Compare with previous version

added 1 commit <ul><li>69c9a96d - Added an html linter. It doesn&#39;t produce any errors. Either the code is...</li></ul> [Compare with previous version](/patek-devs/patek.cz/merge_requests/1/diffs?diff_id=48701110&start_sha=8f88e54299793856435f76e02a92ac0d2f3562d8)
Greenscreener commented 2019-07-19 10:34:45 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

added 1 commit

Compare with previous version

added 1 commit <ul><li>e6f64ef9 - Added sass linting.</li></ul> [Compare with previous version](/patek-devs/patek.cz/merge_requests/1/diffs?diff_id=48704217&start_sha=69c9a96d25b10a9cb8b227558916c4946c46df48)
Greenscreener commented 2019-07-19 10:36:20 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

unmarked as a Work In Progress

unmarked as a **Work In Progress**
Greenscreener commented 2019-07-19 10:36:59 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

I think we're essentially ready for merge if you guys agree.

I think we're essentially ready for merge if you guys agree.
Greenscreener commented 2019-07-19 10:39:21 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

Since I don't think GitLab has review requests as of yet, I'll just tag @sijisu and @vojta001.

Since I don't think GitLab has review requests as of yet, I'll just tag @sijisu and @vojta001.
Greenscreener commented 2019-07-19 11:09:20 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

added 3 commits

  • c63825bf - Enable Gitlab CI to test buildability.
  • 7cbcef39 - Merge branch 'vojta001/gitlab-ci' of gitlab.com:patek-devs/patek.cz into linters
  • cb062f0b - Added linting to .gitlab-ci.yml

Compare with previous version

added 3 commits <ul><li>c63825bf - Enable Gitlab CI to test buildability.</li><li>7cbcef39 - Merge branch &#39;vojta001/gitlab-ci&#39; of gitlab.com:patek-devs/patek.cz into linters</li><li>cb062f0b - Added linting to .gitlab-ci.yml</li></ul> [Compare with previous version](/patek-devs/patek.cz/merge_requests/1/diffs?diff_id=48707865&start_sha=e6f64ef997ce364766b7d5f879b0753d23d51ae8)
Greenscreener commented 2019-07-19 11:22:11 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

added 1 commit

Compare with previous version

added 1 commit <ul><li>a0a8f355 - Fixed typo.</li></ul> [Compare with previous version](/patek-devs/patek.cz/merge_requests/1/diffs?diff_id=48709090&start_sha=cb062f0b7d52fcecd56fb6d98533a3c0ede39b22)
Greenscreener commented 2019-07-19 11:32:43 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

added 1 commit

Compare with previous version

added 1 commit <ul><li>1783ad93 - WIP</li></ul> [Compare with previous version](/patek-devs/patek.cz/merge_requests/1/diffs?diff_id=48710212&start_sha=a0a8f355efa2ecb65db7e57a692fd4d65e625871)
Greenscreener commented 2019-07-19 11:32:44 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

marked as a Work In Progress from 1783ad9306

marked as a **Work In Progress** from 1783ad9306d77db2ef3eda2807dd398e3a533f91
Greenscreener commented 2019-07-19 11:43:47 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

added 1 commit

Compare with previous version

added 1 commit <ul><li>5fc314e7 - WIP</li></ul> [Compare with previous version](/patek-devs/patek.cz/merge_requests/1/diffs?diff_id=48711269&start_sha=1783ad9306d77db2ef3eda2807dd398e3a533f91)
vojta001 commented 2019-07-19 11:49:46 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

But it can be used separately as well and getting linting results in job logs of this project is of little value for the development and maintenance of the logo itself.

And then there is Bulma...

But it can be used separately as well and getting linting results in job logs of this project is of little value for the development and maintenance of the logo itself. And then there is Bulma...
Greenscreener commented 2019-07-19 11:54:25 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

Yes, bulma is ignored, because it uses sass files and we lint only scss.

Yes, bulma is ignored, because it uses sass files and we lint only scss.
Greenscreener commented 2019-07-19 11:56:57 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

added 1 commit

Compare with previous version

added 1 commit <ul><li>0ca34bb9 - Ah bollocks...</li></ul> [Compare with previous version](/patek-devs/patek.cz/merge_requests/1/diffs?diff_id=48712648&start_sha=5fc314e79e447eecc9bef5786b3e55f3a64a9e7d)
Greenscreener commented 2019-07-19 12:05:07 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

unmarked as a Work In Progress

unmarked as a **Work In Progress**
Greenscreener commented 2019-07-19 12:18:21 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

added 1 commit

  • c97bbb18 - Added Makefile for local linting and checking.

Compare with previous version

added 1 commit <ul><li>c97bbb18 - Added Makefile for local linting and checking.</li></ul> [Compare with previous version](/patek-devs/patek.cz/merge_requests/1/diffs?diff_id=48716535&start_sha=0ca34bb9f52237dd10c8a4984220876a38eb7e10)
Greenscreener commented 2019-07-19 15:57:09 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

unassigned @Greenscreener

unassigned @Greenscreener
vojta001 commented 2019-07-21 15:20:19 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

I think we can slowly move to merging this to master. Are you OK with me doing some polishing by rewriting your carefully written history? The same applies for !2 especially since these two are connected so much

I think we can slowly move to merging this to `master`. Are you OK with me doing some polishing by rewriting your carefully written history? The same applies for !2 especially since these two are connected so much
Greenscreener commented 2019-07-21 16:51:30 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

Well, you could merge just firebase-deploy, since that already contains all changes. Also, didn't we talk about putting deployment/building/production related stuff into a separate branch? Yea, a cleanup of the history would be nice.

Well, you could merge just firebase-deploy, since that already contains all changes. Also, didn't we talk about putting deployment/building/production related stuff into a separate branch? Yea, a cleanup of the history would be nice.
vojta001 commented 2019-07-23 10:07:33 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

added 6 commits

  • 1802ae01 - Added js linter config.
  • 53147093 - Added an html linter. It doesn't produce any errors. Either the code is...
  • 5ed936d5 - Added sass linting.
  • 99aa6da0 - Merge branch 'vojta001/gitlab-ci' of gitlab.com:patek-devs/patek.cz into linters
  • 8331f0a7 - Added linting to .gitlab-ci.yml
  • 111761f8 - Added Makefile for local linting and checking.

Compare with previous version

added 6 commits <ul><li>1802ae01 - Added js linter config.</li><li>53147093 - Added an html linter. It doesn&#39;t produce any errors. Either the code is...</li><li>5ed936d5 - Added sass linting.</li><li>99aa6da0 - Merge branch &#39;vojta001/gitlab-ci&#39; of gitlab.com:patek-devs/patek.cz into linters</li><li>8331f0a7 - Added linting to .gitlab-ci.yml</li><li>111761f8 - Added Makefile for local linting and checking.</li></ul> [Compare with previous version](/patek-devs/patek.cz/merge_requests/1/diffs?diff_id=48986691&start_sha=c97bbb184e802755bb4a025ab6af32b18f2b12a3)
vojta001 commented 2019-07-23 10:42:36 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

I've finally done the cleanup.

I think we should finish the master/production and CI/CD discussion and whether to lint external code discussion before merging.

I've finally done the cleanup. I think we should finish the *`master`/`production` and CI/CD* discussion and *whether to lint external code* discussion before merging.
Greenscreener commented 2019-07-23 14:56:04 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

We should probably merge the last commit from master, since it has code style updates relevant for this branch and the lint jobs will fail.

We should probably merge the last commit from master, since it has code style updates relevant for this branch and the lint jobs will fail.
Greenscreener commented 2019-07-25 10:42:22 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

We decided to make the two branches identical, the only difference is that deploy and build happen only on production.

We decided to make the two branches identical, the only difference is that deploy and build happen only on production.
Greenscreener commented 2019-07-25 10:42:43 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

merged

merged
Greenscreener commented 2019-07-25 10:42:44 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

mentioned in commit 3fb47992db

mentioned in commit 3fb47992dba80aa2019733e7fa6d5dda6891fb26
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
easy pick
enhancement
fixneeded
help wanted
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
Broxon Dejwut (David Pacák) genibro (Michail Kornilov) jakub_kutsch (Jakub Kutscherauer) jan (Jan Černohorský) OndreasCZ (Ondřej Novák) sijisu (Šimon Jan Šustek) tomkys144 (Tomáš Kysela) vojta001 (Vojtěch Káně)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: patek/patek.cz#22