patek/patek.cz
9
0
Fork 0
Code Issues 4 Pull Requests 2 Packages Projects Releases Wiki Activity

A big improvement for dakrmode. #35

Merged
Greenscreener merged 0 commits from gs/darkmode-fix into master 2020-04-28 09:47:53 +00:00
Conversation 5 Commits - Files Changed -
Greenscreener commented 2020-04-26 19:13:17 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

This fixes issue #11 completely and #10 in its original form.

Regarding the flashes, after I removed the transitions it looks fine now and is IMHO not noticeable if you don't look for it. This should autoclose both #10 and #11, so if we want to look for an even better fix to remove the blinking entirely, we should create a new issue the description of which will describe this problem more accurately.

This fixes issue #11 completely and #10 in its original form. Regarding the flashes, after I removed the transitions it looks fine now and is IMHO not noticeable if you don't look for it. This should autoclose both #10 and #11, so if we want to look for an even better fix to remove the blinking entirely, we should create a new issue the description of which will describe this problem more accurately.
vojta001 (Migrated from gitlab.com) approved these changes 2020-04-26 19:13:17 +00:00
vojta001 commented 2020-04-27 18:33:00 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

approved this merge request

approved this merge request
vojta001 commented 2020-04-27 18:33:00 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

👍 definitely a huge improvement. The only part, I could notice, that still transitions, are headings, which looks fine

👍 definitely a huge improvement. The only part, I could notice, that still transitions, are headings, which looks fine
Greenscreener commented 2020-04-28 09:47:53 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

mentioned in commit 897eb88bec

mentioned in commit 897eb88becbcbf8b483bf48c6d6853be15ac8392
Greenscreener commented 2020-04-28 09:47:53 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

merged

merged
Sign in to join this conversation.
Reviewers
No Reviewers
vojta001
Labels
Clear labels
bug
easy pick
enhancement
fixneeded
help wanted
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
Broxon Dejwut (David Pacák) genibro (Michail Kornilov) jakub_kutsch (Jakub Kutscherauer) jan (Jan Černohorský) OndreasCZ (Ondřej Novák) sijisu (Šimon Jan Šustek) tomkys144 (Tomáš Kysela) vojta001 (Vojtěch Káně)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: patek/patek.cz#35