patek/patek.cz
9
0
Fork 0
Code Issues 4 Pull Requests 2 Packages Projects Releases Wiki Activity

Added fallback CSS for PatekLogos. #43

Merged
Greenscreener merged 1 commits from gs/patek-logo-fallback into vojta001/patek-logo-fallback 2020-05-14 17:55:46 +00:00
Conversation 9 Commits 1 Files Changed 1
+3 -2
Greenscreener commented 2020-05-12 09:32:53 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source
No description provided.
vojta001 (Migrated from gitlab.com) approved these changes 2020-05-12 09:32:53 +00:00
Greenscreener commented 2020-05-12 09:33:32 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

mentioned in merge request !21

mentioned in merge request !21
vojta001 commented 2020-05-12 14:18:08 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

I think this is really an overkill not worth the time, but we can of course merge it since you already spent time doing it. In such a case, please add a comment to the SCSS explaining why it is there. I would be confused if I met it there, since styling of a custom element should be packed inside the element.

I think this is really an overkill not worth the time, but we can of course merge it since you already spent time doing it. In such a case, please add a comment to the SCSS explaining why it is there. I would be confused if I met it there, since styling of a custom element should be packed inside the element.
vojta001 commented 2020-05-13 21:31:58 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

ping

ping
Greenscreener commented 2020-05-13 21:34:56 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

Yeah sorry, I completely forgot about this.

Yeah sorry, I completely forgot about this.
Greenscreener commented 2020-05-14 16:47:24 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

added 1 commit

Compare with previous version

added 1 commit <ul><li>8f48a12a - Added explaining comment.</li></ul> [Compare with previous version](/patek-devs/patek.cz/-/merge_requests/22/diffs?diff_id=90579675&start_sha=b0c1775f10f30696fcb95380aa303dba2d233c44)
vojta001 commented 2020-05-14 17:55:07 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

approved this merge request

approved this merge request
Greenscreener commented 2020-05-14 17:55:46 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

mentioned in commit fcf2bf220e

mentioned in commit fcf2bf220e0f94e6b2e2a158351596838613d205
Greenscreener commented 2020-05-14 17:55:46 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

merged

merged
Sign in to join this conversation.
Reviewers
No Reviewers
vojta001
Labels
Clear labels
bug
easy pick
enhancement
fixneeded
help wanted
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
Broxon Dejwut (David Pacák) genibro (Michail Kornilov) jakub_kutsch (Jakub Kutscherauer) jan (Jan Černohorský) OndreasCZ (Ondřej Novák) sijisu (Šimon Jan Šustek) tomkys144 (Tomáš Kysela) vojta001 (Vojtěch Káně)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: patek/patek.cz#43