patek/patek.cz
9
0
Fork 0
Code Issues 4 Pull Requests 2 Packages Projects Releases Wiki Activity

Suggestion: Add online-only notice. #60

Merged
Greenscreener merged 0 commits from gs/online-only-notice into master 2020-10-18 11:14:04 +00:00
Conversation 24 Commits - Files Changed -
Greenscreener commented 2020-10-05 00:58:32 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

This is just a suggestion, adds an online-only banner over the logo on the homepage. I myself am not exactly sure if we want this, gimme your opinions.

image

This is just a suggestion, adds an online-only banner over the logo on the homepage. I myself am not exactly sure if we want this, gimme your opinions. ![image](/uploads/dd0220862a3972fff8e2eb1a2280b956/image.png)
sijisu (Migrated from gitlab.com) approved these changes 2020-10-05 00:58:32 +00:00
vojta001 (Migrated from gitlab.com) approved these changes 2020-10-05 00:58:32 +00:00
vojta001 commented 2020-10-05 20:42:41 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

Well, no offense, but I am not a huge fan of this change. Not strictly against it either, but, hm, I don't know… it looks like a banner for a huge sale while actually selling COVID. I mean, I am not sure about the message it carries. However, as I said, one approval and I STFU.

Well, no offense, but I am not a huge fan of this change. Not strictly against it either, but, hm, I don't know… it looks like a banner for a huge sale while actually selling COVID. I mean, I am not sure about the message it carries. However, as I said, one approval and I STFU.
Greenscreener commented 2020-10-05 20:48:40 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

I'm not really a fan of this either, I just had a thought and I wanted to try it. Anyway, we still might want to get some indicator of the availability of offline/online meetings, ideally on the landing page, since it might change quite rapidly in the coming weeks and months.

I'm not really a fan of this either, I just had a thought and I wanted to try it. Anyway, we still might want to get some indicator of the availability of offline/online meetings, ideally on the landing page, since it might change quite rapidly in the coming weeks and months.
sijisu commented 2020-10-06 14:09:11 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

I think it's kinda cool, but I would prefer something like "COVID mode", "Online mode" or "Safe mode". Which I think are more understandable.

I think it's kinda cool, but I would prefer something like "COVID mode", "Online mode" or "Safe mode". Which I think are more understandable.
tomkys144 commented 2020-10-14 15:23:43 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

approved this merge request

approved this merge request
sijisu commented 2020-10-14 21:17:16 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

What's the status on this, guys? Do we want it?

I think it would be cool to have, with one of the alternative texts I suggested.

I think "online mode" is the most suitable. What do you think?

What's the status on this, guys? Do we want it? I think it would be cool to have, with one of the alternative texts I suggested. I think "online mode" is the most suitable. What do you think?
vojta001 commented 2020-10-15 06:46:52 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

Yeah, I support both online mode and COVID mode.

Yeah, I support both _online mode_ and _COVID mode_.
tomkys144 commented 2020-10-15 07:20:02 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

I support "online mode" more. At least, we can recycle the notice, if any other crisis happens...

I support "online mode" more. At least, we can recycle the notice, if any other crisis happens...
Greenscreener commented 2020-10-15 10:12:48 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

added 1 commit

Compare with previous version

added 1 commit <ul><li>610bb62f - Added online-only notice.</li></ul> [Compare with previous version](/patek-devs/patek.cz/-/merge_requests/39/diffs?diff_id=118326625&start_sha=a89fde5fbac57f18509aa439e3f825fd1264f67c)
Greenscreener commented 2020-10-15 10:21:02 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

added 1 commit

  • 192672a2 - Added programmatic switching of online mode to config.

Compare with previous version

added 1 commit <ul><li>192672a2 - Added programmatic switching of online mode to config.</li></ul> [Compare with previous version](/patek-devs/patek.cz/-/merge_requests/39/diffs?diff_id=118328761&start_sha=610bb62f30a1a23f2fcca3d0088449bf53a3f394)
sijisu commented 2020-10-15 10:22:17 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

resolved all threads

resolved all threads
sijisu commented 2020-10-15 10:23:19 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

approved this merge request

approved this merge request
vojta001 commented 2020-10-15 10:24:21 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

Inconsistent whitespace

Inconsistent whitespace
vojta001 commented 2020-10-15 10:24:21 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

Inconsistent whitespace

Inconsistent whitespace
Greenscreener commented 2020-10-15 10:32:17 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

changed this line in version 5 of the diff

changed this line in [version 5 of the diff](/patek-devs/patek.cz/-/merge_requests/39/diffs?diff_id=118331665&start_sha=192672a2cd7bfeba982eb93347dcdad1d0f87ab8#2d0c6f68a1326d5d236f1938827043df6bfb6b85_36_36)
Greenscreener commented 2020-10-15 10:32:17 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

changed this line in version 5 of the diff

changed this line in [version 5 of the diff](/patek-devs/patek.cz/-/merge_requests/39/diffs?diff_id=118331665&start_sha=192672a2cd7bfeba982eb93347dcdad1d0f87ab8#c5fd3201494e82cf94e6a681cdc535b306134e1a_21_15)
Greenscreener commented 2020-10-15 10:32:18 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

added 1 commit

  • 2fbd3f94 - Added programmatic switching of online mode to config.

Compare with previous version

added 1 commit <ul><li>2fbd3f94 - Added programmatic switching of online mode to config.</li></ul> [Compare with previous version](/patek-devs/patek.cz/-/merge_requests/39/diffs?diff_id=118331665&start_sha=192672a2cd7bfeba982eb93347dcdad1d0f87ab8)
Greenscreener commented 2020-10-15 10:32:54 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

Wait, why is everything indented with spaces, didn't we decide on using tabs?

Wait, why is everything indented with spaces, didn't we decide on using tabs?
vojta001 commented 2020-10-15 10:47:07 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

We did. But we never unified existing codebase. I tried to do so, but before finishing it, there were so many new commits I didn't bother merging. I can push it for reference

We did. But we never unified existing codebase. I tried to do so, but before finishing it, there were so many new commits I didn't bother merging. I can push it for reference
vojta001 commented 2020-10-15 10:47:13 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

approved this merge request

approved this merge request
vojta001 commented 2020-10-15 10:47:42 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

038229aacf

038229aacf76bed7621f59f5cba3cdebc91fddce
sijisu commented 2020-10-16 12:00:35 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

approved this merge request

approved this merge request
Greenscreener commented 2020-10-18 11:14:05 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

mentioned in commit d914a323f1

mentioned in commit d914a323f1d49104ccbf568a0f51d217ac4b1d86
Sign in to join this conversation.
Reviewers
No Reviewers
sijisu
vojta001
Labels
Clear labels
bug
easy pick
enhancement
fixneeded
help wanted
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
Broxon Dejwut (David Pacák) genibro (Michail Kornilov) jakub_kutsch (Jakub Kutscherauer) jan (Jan Černohorský) OndreasCZ (Ondřej Novák) sijisu (Šimon Jan Šustek) tomkys144 (Tomáš Kysela) vojta001 (Vojtěch Káně)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: patek/patek.cz#60