patek/patek.cz
9
0
Fork 0
Code Issues 4 Pull Requests 2 Packages Projects Releases Wiki Activity

Make .has-text-grey constrast enought with white to pass the WCAG AA requirements #63

Merged
vojta001 merged 0 commits from vojta001/grey-text into master 2020-10-07 16:10:49 +00:00
Conversation 11 Commits - Files Changed -
vojta001 commented 2020-10-07 10:03:33 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

While being unspottable with the naked eye, this will make some pages of your site formally accessible (blog listing for example).

While being unspottable with the naked eye, this will make some pages of your site formally accessible (blog listing for example).
Greenscreener (Migrated from gitlab.com) approved these changes 2020-10-07 10:03:33 +00:00
Greenscreener commented 2020-10-07 10:11:44 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

I know I kinda asked for this with 80ac584b16, but redefining the colour helper classes feels a little wrong.

I know I kinda asked for this with 80ac584b16cdfb40a5fa5a8c0d28a23fe2751969, but redefining the colour helper classes feels a little wrong.
vojta001 commented 2020-10-07 10:16:05 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

Yeah, it feels. But is there a better way? Bulma hardcodes this value instead of having a variable AFAIK.

Yeah, it feels. But is there a better way? Bulma hardcodes this value instead of having a variable AFAIK.
Greenscreener commented 2020-10-07 10:32:51 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

It's $grey-dark AFAIK. The only reasonable solution for me is to drop the change of colour all together and have it the same colour as the rest of the text. If we raise the contrast with the background, it the contrast with the rest of the text will be so small it might just not be there.

It's `$grey-dark` AFAIK. The only reasonable solution for me is to drop the change of colour all together and have it the same colour as the rest of the text. If we raise the contrast with the background, it the contrast with the rest of the text will be so small it might just not be there.
vojta001 commented 2020-10-07 10:56:44 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

I don't this this is necessary. As I stated in the description, #737373 and #7a7a7a are almost the same colors, excepts the later one does not pass the requirements. With the change applied, I can still see the text as grey and it makes a nice visual distinction.

I don't this this is necessary. As I stated in the description, `#737373` and `#7a7a7a` are almost the same colors, excepts the later one does not pass the requirements. With the change applied, I can still see the text as grey and it makes a nice visual distinction.
Greenscreener commented 2020-10-07 11:12:12 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

Hmmm, sure. Let's merge in the changes from !38, since this is closely related with 80ac584.

Hmmm, sure. Let's merge in the changes from !38, since this is closely related with 80ac584.
vojta001 commented 2020-10-07 11:43:44 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

You mean merge !38 into !42, or merge !38 into master? I don't think these are tightly related, so I would just wait for !38 approval and merge it. The same with this one (not necessarily in this order).

You mean merge !38 into !42, or merge !38 into master? I don't think these are tightly related, so I would just wait for !38 approval and merge it. The same with this one (not necessarily in this order).
Greenscreener commented 2020-10-07 12:38:05 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

Sure.

Sure.
vojta001 commented 2020-10-07 14:32:04 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

Then approve this one please

Then approve this one please
Greenscreener commented 2020-10-07 15:43:04 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

approved this merge request

approved this merge request
vojta001 commented 2020-10-07 16:10:49 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

mentioned in commit 9230d8e16c

mentioned in commit 9230d8e16c8392304eeb66906225fe191202847d
Sign in to join this conversation.
Reviewers
No Reviewers
Greenscreener
Labels
Clear labels
bug
easy pick
enhancement
fixneeded
help wanted
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
Broxon Dejwut (David Pacák) genibro (Michail Kornilov) jakub_kutsch (Jakub Kutscherauer) jan (Jan Černohorský) OndreasCZ (Ondřej Novák) sijisu (Šimon Jan Šustek) tomkys144 (Tomáš Kysela) vojta001 (Vojtěch Káně)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: patek/patek.cz#63