patek/patek.cz
9
0
Fork 0
Code Issues 4 Pull Requests 2 Packages Projects Releases Wiki Activity

Support talks iCal output #72

Merged
vojta001 merged 0 commits from vojta001/talks-cal into master 2020-11-13 15:00:16 +00:00
Conversation 17 Commits - Files Changed -
vojta001 commented 2020-11-10 19:29:43 +00:00 (Migrated from gitlab.com)
Copy Link
No description provided.
sijisu (Migrated from gitlab.com) approved these changes 2020-11-10 19:29:43 +00:00
tomkys144 (Migrated from gitlab.com) approved these changes 2020-11-10 19:29:43 +00:00
Greenscreener commented 2020-11-10 19:39:27 +00:00 (Migrated from gitlab.com)
Copy Link

M8, it's broken: https://gitlab.com/patek-devs/patek.cz/-/pipelines/214397932

M8, it's broken: https://gitlab.com/patek-devs/patek.cz/-/pipelines/214397932
vojta001 commented 2020-11-10 19:47:31 +00:00 (Migrated from gitlab.com)
Copy Link

I know. I suspect it is because of different Hugo versions. I'll investigate.

I know. I suspect it is because of different Hugo versions. I'll investigate.
vojta001 commented 2020-11-10 20:24:13 +00:00 (Migrated from gitlab.com)
Copy Link

cascade was added to front matter in Hugo v0.57.0

`cascade` was added to front matter in Hugo [v0.57.0](https://github.com/gohugoio/hugo/releases/tag/v0.57.0)
vojta001 commented 2020-11-10 21:01:18 +00:00 (Migrated from gitlab.com)
Copy Link

added 2 commits

  • 24c59f3b - Update Hugo from 0.55.6 to 0.78.1
  • 9fb41b7b - Merge branch 'vojta001/update-hugo' into vojta001/talks-cal

Compare with previous version

added 2 commits <ul><li>24c59f3b - Update Hugo from 0.55.6 to 0.78.1</li><li>9fb41b7b - Merge branch &#39;vojta001/update-hugo&#39; into vojta001/talks-cal</li></ul> [Compare with previous version](/patek-devs/patek.cz/-/merge_requests/51/diffs?diff_id=123760669&start_sha=0fcc265bb953c3d811cb19e1ee921d489a3113a9)
Greenscreener commented 2020-11-10 21:24:54 +00:00 (Migrated from gitlab.com)
Copy Link

Sounds cool, but clicking the buttons does nothing in Firefox.

Sounds cool, but clicking the buttons does nothing in Firefox.
vojta001 commented 2020-11-10 22:03:12 +00:00 (Migrated from gitlab.com)
Copy Link

Can you please post the link target? Also keep in mind the protocol (or more like pseudo protocol) is webcal:// which is supported by calendar apps, not web browsers (even though it is accessed over HTTP(S)).

Can you please post the link target? Also keep in mind the protocol (or more like pseudo protocol) is `webcal://` which is supported by calendar apps, not web browsers (even though it is accessed over HTTP(S)).
vojta001 commented 2020-11-10 22:08:41 +00:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • 1f5e311c - Explicitly enable RSS output format for talks

Compare with previous version

added 1 commit <ul><li>1f5e311c - Explicitly enable RSS output format for talks</li></ul> [Compare with previous version](/patek-devs/patek.cz/-/merge_requests/51/diffs?diff_id=123769510&start_sha=9fb41b7b4aea5e9048a9505c5a0a879b45c8e23a)
Greenscreener commented 2020-11-10 22:21:43 +00:00 (Migrated from gitlab.com)
Copy Link

The link points to webcal://localhost:1313/talks/install-gentoo/index.ics it seems that I just don't have the feature set up on my desktop. I tried following this tutorial: https://support.mozilla.org/en-US/questions/1196085, and it now works with google calendar, but inserts an empty calendar which might be caused by the fact I'm on localhost. I didn't manage to get it working on Android, both with Chrome and Firefox. The page just loads for a split second and nothing happens.

The link points to `webcal://localhost:1313/talks/install-gentoo/index.ics` it seems that I just don't have the feature set up on my desktop. I tried following this tutorial: https://support.mozilla.org/en-US/questions/1196085, and it now works with google calendar, but inserts an empty calendar which might be caused by the fact I'm on localhost. I didn't manage to get it working on Android, both with Chrome and Firefox. The page just loads for a split second and nothing happens.
vojta001 commented 2020-11-11 08:42:11 +00:00 (Migrated from gitlab.com)
Copy Link

I cannot agree; it works fine for me even using the outputs from the CI.

image

I cannot agree; it works fine for me even using the outputs from the CI. ![image](/uploads/86a1aaa30f0621366dbf70431ee4ff68/image.png)
sijisu commented 2020-11-12 12:45:18 +00:00 (Migrated from gitlab.com)
Copy Link

Cannot test rn, but looks good

Cannot test rn, but looks good
sijisu commented 2020-11-12 12:45:24 +00:00 (Migrated from gitlab.com)
Copy Link

approved this merge request

approved this merge request
Greenscreener commented 2020-11-12 12:50:02 +00:00 (Migrated from gitlab.com)
Copy Link

Still doesn't work on my phone and I think it's not a problem on my side

Still doesn't work on my phone and I think it's not a problem on my side
vojta001 commented 2020-11-12 12:59:36 +00:00 (Migrated from gitlab.com)
Copy Link

Well, what did you try? Are you pasting the link to your calendar app?

Well, what did you try? Are you pasting the link to your calendar app?
tomkys144 commented 2020-11-13 14:59:02 +00:00 (Migrated from gitlab.com)
Copy Link

approved this merge request

approved this merge request
vojta001 commented 2020-11-13 15:00:16 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 5ca2d9b301

mentioned in commit 5ca2d9b301104e6145535afbad9d4adfa83ac29c
vojta001 commented 2020-11-13 16:44:07 +00:00 (Migrated from gitlab.com)
Copy Link

resolved all threads

resolved all threads
vojta001 commented 2020-11-13 16:45:19 +00:00 (Migrated from gitlab.com)
Copy Link

After a personal discussion, we decided to deploy it as is including the usage of webcal:// and eventually change it to http(s):// later, if it show to be better.

After a personal discussion, we decided to deploy it as is including the usage of `webcal://` and eventually change it to `http(s)://` later, if it show to be better.
Sign in to join this conversation.
Reviewers
No reviewers
sijisu
tomkys144
Labels
Clear labels   
bug

   
easy pick

   
enhancement

   
fixneeded

   
help wanted
No Label
bug
easy pick
enhancement
fixneeded
help wanted
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: patek/patek.cz#72
No description provided.
Delete Branch "vojta001/talks-cal"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?