patek/patek.cz
9
0
Fork 0
Code Issues 4 Pull Requests 2 Packages Projects Releases Wiki Activity

Update Hugo from 0.55.6 to 0.78.1 #74

Merged
vojta001 merged 0 commits from vojta001/update-hugo into master 2020-11-11 15:10:28 +00:00
Conversation 10 Commits - Files Changed -
vojta001 commented 2020-11-10 20:57:56 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source
No description provided.
Greenscreener (Migrated from gitlab.com) approved these changes 2020-11-10 20:57:56 +00:00
sijisu (Migrated from gitlab.com) approved these changes 2020-11-10 20:57:56 +00:00
sijisu commented 2020-11-10 21:09:06 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

approved this merge request

approved this merge request
Greenscreener commented 2020-11-10 21:09:44 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

Are those other changes related?

Are those other changes related?
vojta001 commented 2020-11-10 21:58:58 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

Somehow. It depends whether we accept this as atomic enough, but I feel it is related.

The markdown renderer used by Hugo changed, and its current default (unlike the previous one) is to drop raw HTML in content, which breaks some of our pages that use it.

Also the detection of missing translations changed. It detects not only missing languages, but also missing plural/singular forms. The missing translations were in fact a bug even before updating Hugo, but the new versions made me aware of it and also made it impossible to build the site (at least with our requirements of not producing any missing translations warnings).

Somehow. It depends whether we accept this as _atomic enough_, but I feel it is related. The markdown renderer used by Hugo changed, and its current default (unlike the previous one) is to drop raw HTML in content, which breaks some of our pages that use it. Also the detection of missing translations changed. It detects not only missing languages, but also missing plural/singular forms. The missing translations were in fact a bug even before updating Hugo, but the new versions made me aware of it and also made it impossible to build the site (at least with our requirements of not producing any missing translations warnings).
vojta001 commented 2020-11-11 13:08:37 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

Do you agree?

Do you agree?
Greenscreener commented 2020-11-11 14:04:00 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

yeah sure.

yeah sure.
Greenscreener commented 2020-11-11 14:04:02 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

resolved all threads

resolved all threads
Greenscreener commented 2020-11-11 14:04:05 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

approved this merge request

approved this merge request
vojta001 commented 2020-11-11 15:10:28 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

mentioned in commit 4b933552b4

mentioned in commit 4b933552b480578b83656df9cfeea18d002f7196
Sign in to join this conversation.
Reviewers
No Reviewers
Greenscreener
sijisu
Labels
Clear labels
bug
easy pick
enhancement
fixneeded
help wanted
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
Broxon Dejwut (David Pacák) genibro (Michail Kornilov) jakub_kutsch (Jakub Kutscherauer) jan (Jan Černohorský) OndreasCZ (Ondřej Novák) sijisu (Šimon Jan Šustek) tomkys144 (Tomáš Kysela) vojta001 (Vojtěch Káně)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: patek/patek.cz#74