patek/patek.cz
9
0
Fork 0
Code Issues 4 Pull Requests 2 Packages Projects Releases Wiki Activity

Add links to RSS #75

Merged
vojta001 merged 0 commits from vojta001/links-to-rss into master 2020-12-15 08:13:39 +00:00
Conversation 9 Commits - Files Changed -
vojta001 commented 2020-11-11 12:39:25 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

We have been supporting RSS from the beginning, but it wasn't immediately obvious. The RSS we generate stays the same, only links were added.

Given the current styling, I had to enforce paginator display even when there is only one page.

We have been supporting RSS from the beginning, but it wasn't immediately obvious. The RSS we generate stays the same, only links were added. Given the current styling, I had to enforce paginator display even when there is only one page.
Greenscreener (Migrated from gitlab.com) approved these changes 2020-11-11 12:39:25 +00:00
Greenscreener commented 2020-11-13 17:01:04 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

I am against the enforced paginator thing, I'll try to rewrite so this is not required.

I am against the enforced paginator thing, I'll try to rewrite so this is not required.
vojta001 commented 2020-12-13 08:23:09 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

Ping. An ugly yet working solution is to nest the condition such, that when no paginator shall be drawn, an empty div is written out. That effectively hides the paginator while leaving something for the flexbox to position accordingly.

Ping. An ugly yet working solution is to nest the condition such, that when no paginator shall be drawn, an empty div is written out. That effectively hides the paginator while leaving something for the flexbox to position accordingly.
Greenscreener commented 2020-12-14 20:15:28 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

added 2 commits

  • b73729c3 - Made a better layout for rel-alternate buttons.
  • a0bf26b4 - Enclosed rel-alternate links in buttons.

Compare with previous version

added 2 commits <ul><li>b73729c3 - Made a better layout for rel-alternate buttons.</li><li>a0bf26b4 - Enclosed rel-alternate links in buttons.</li></ul> [Compare with previous version](/patek-devs/patek.cz/-/merge_requests/54/diffs?diff_id=130831167&start_sha=685ed5d809b945c0a117eb5ad8e0ebe53fc420a5)
Greenscreener commented 2020-12-14 20:21:16 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

added 1 commit

  • ec974fbe - Replced sqare rss icon with the normal one for buttons.

Compare with previous version

added 1 commit <ul><li>ec974fbe - Replced sqare rss icon with the normal one for buttons.</li></ul> [Compare with previous version](/patek-devs/patek.cz/-/merge_requests/54/diffs?diff_id=130832166&start_sha=a0bf26b45900beebecd7f62544585cdbdfd790d4)
Greenscreener commented 2020-12-14 20:22:06 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

Sorry for making you wait for so long, I finally got around to making a proper layout for the buttons. The last two commits contain an optional change: I enclosed the icons in buttons, because it drove me mad how they were optically misaligned. (They still are, but it's not visible as much)

Before:

image

After:

image

Sorry for making you wait for so long, I finally got around to making a proper layout for the buttons. The last two commits contain an optional change: I enclosed the icons in buttons, because it drove me mad how they were optically misaligned. (They still are, but it's not visible as much) Before: ![image](/uploads/2f8632acb13017da667085a2cfbeb0ba/image.png) After: ![image](/uploads/3857979808d4b4613466a9fdb2e574ba/image.png)
vojta001 commented 2020-12-14 22:00:09 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

Honestly, I like these icons much less than the previous ones, but whatever. Can we merge?

Honestly, I like these icons much less than the previous ones, but whatever. Can we merge?
Greenscreener commented 2020-12-14 22:01:04 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

approved this merge request

approved this merge request
vojta001 commented 2020-12-15 08:13:40 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

mentioned in commit ea2df0c26a

mentioned in commit ea2df0c26a97dc9b8ff42853205c49a2a7e0c715
Sign in to join this conversation.
Reviewers
No Reviewers
Greenscreener
Labels
Clear labels
bug
easy pick
enhancement
fixneeded
help wanted
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
Broxon Dejwut (David Pacák) genibro (Michail Kornilov) jakub_kutsch (Jakub Kutscherauer) jan (Jan Černohorský) OndreasCZ (Ondřej Novák) sijisu (Šimon Jan Šustek) tomkys144 (Tomáš Kysela) vojta001 (Vojtěch Káně)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: patek/patek.cz#75